Summary: | [Modern Media Controls] Use modern-media-controls module sources for media controls stylesheet and script injection | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, graouts, kondapallykalyan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 10 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 163501, 163502, 163539 | ||||||||
Attachments: |
|
Description
Antoine Quint
2016-10-16 06:39:42 PDT
Created attachment 291745 [details]
Patch
Created attachment 291834 [details]
Patch for landing
Comment on attachment 291834 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=291834&action=review > Source/WebCore/rendering/RenderThemeMac.mm:241 > + NSArray* paths = @[@"airplay-button", @"button", @"buttons-container", @"icon-button", @"macos-inline-media-controls", @"media-controls", @"placard", @"scrubber", @"slider", @"start-button", @"time-label", @"volume-slider"]; > + for (NSString* path in paths) These should be NSArray *paths and NSString *path. See https://webkit.org/code-style-guidelines/#pointers-and-references (although there is little consistency throughout WebKit here) > Source/WebCore/rendering/RenderThemeMac.mm:261 > + NSArray* controlsPaths = @[@"scheduler", @"layout-node", @"layout-item", @"icon-service", @"time-control", @"time-label", @"slider", @"volume-slider", @"scrubber", @"button", @"start-button", @"icon-button", @"play-pause-button", @"skip-back-button", @"mute-button", @"airplay-button", @"pip-button", @"tracks-button", @"fullscreen-button", @"aspect-ratio-button", @"rewind-button", @"forward-button", @"media-controls", @"macos-media-controls", @"macos-inline-media-controls", @"buttons-container", @"placard", @"airplay-placard", @"pip-placard"]; > + for (NSString* path in controlsPaths) Same here. Comment on attachment 291834 [details] Patch for landing Clearing flags on attachment: 291834 Committed r207418: <http://trac.webkit.org/changeset/207418> All reviewed patches have been landed. Closing bug. |