Bug 163480

Summary:

CounterNode::resetRenderers is so inefficient.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2016-10-14 20:16:20 PDT

It calls into RenderCounter::invalidate() which in turn calls back to the CounterNode to remove the renderer.
    while (m_rootRenderer)
        m_rootRenderer->invalidate(); // This makes m_rootRenderer point to the next renderer if any since it disconnects the m_rootRenderer from this.

Comment 1 zalan 2016-10-14 20:36:49 PDT

Created attachment 291702 [details]
Patch

Comment 2 WebKit Commit Bot 2016-10-15 07:27:12 PDT

Comment on attachment 291702 [details]
Patch

Clearing flags on attachment: 291702

Committed r207374: <http://trac.webkit.org/changeset/207374>

Comment 3 WebKit Commit Bot 2016-10-15 07:27:16 PDT

All reviewed patches have been landed.  Closing bug.