Bug 163480

Summary: CounterNode::resetRenderers is so inefficient.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2016-10-14 20:16:20 PDT
It calls into RenderCounter::invalidate() which in turn calls back to the CounterNode to remove the renderer. while (m_rootRenderer) m_rootRenderer->invalidate(); // This makes m_rootRenderer point to the next renderer if any since it disconnects the m_rootRenderer from this.
Attachments
Patch (15.35 KB, patch)
2016-10-14 20:36 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2016-10-14 20:36:49 PDT
Created attachment 291702 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-15 07:27:12 PDT
Comment on attachment 291702 [details] Patch Clearing flags on attachment: 291702 Committed r207374: <http://trac.webkit.org/changeset/207374>
WebKit Commit Bot
Comment 3 2016-10-15 07:27:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.