Bug 16346

Summary: [GTK] Some webview parts must use the focused frame
Product: WebKit Reporter: Luca Bruno <lethalman88>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch
none
keep getViewFromFrame alp: review+

Description Luca Bruno 2007-12-07 14:04:13 PST
Hello,
some functions of the webview API is using the main frame instead of the focused frame.
Comment 1 Luca Bruno 2007-12-07 14:25:42 PST
Created attachment 17783 [details]
patch

- Use focused frame where needed
- Update old code
- Fix page up and page down for editable contents

This is the rest of the previous patch here applied to all the code: http://bugs.webkit.org/show_bug.cgi?id=16333
Comment 2 Luca Bruno 2007-12-08 06:32:34 PST
Created attachment 17788 [details]
keep getViewFromFrame

This patch keeps getViewFromFrame and add missing webkitprivate.h diff.
Comment 3 Alp Toker 2007-12-08 06:38:18 PST
Comment on attachment 17788 [details]
keep getViewFromFrame

r=me
Comment 4 Alp Toker 2007-12-08 06:39:58 PST
Landed in r28564.

It's good that we didn't remove getViewFromFrame() since the future of web_frame_get_web_view() is uncertain.

Thanks!