Bug 16346

Summary: [GTK] Some webview parts must use the focused frame
Product: WebKit Reporter: Luca Bruno <lethalman88>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch
none
keep getViewFromFrame alp: review+

Luca Bruno
Reported 2007-12-07 14:04:13 PST
Hello, some functions of the webview API is using the main frame instead of the focused frame.
Attachments
patch (15.21 KB, patch)
2007-12-07 14:25 PST, Luca Bruno 		no flags
DetailsFormatted DiffDiff
keep getViewFromFrame (12.30 KB, patch)
2007-12-08 06:32 PST, Luca Bruno 		alp: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luca Bruno
Comment 1 2007-12-07 14:25:42 PST
Created attachment 17783 [details] patch - Use focused frame where needed - Update old code - Fix page up and page down for editable contents This is the rest of the previous patch here applied to all the code: http://bugs.webkit.org/show_bug.cgi?id=16333
Luca Bruno
Comment 2 2007-12-08 06:32:34 PST
Created attachment 17788 [details] keep getViewFromFrame This patch keeps getViewFromFrame and add missing webkitprivate.h diff.
Alp Toker
Comment 3 2007-12-08 06:38:18 PST
Comment on attachment 17788 [details] keep getViewFromFrame r=me
Alp Toker
Comment 4 2007-12-08 06:39:58 PST
Landed in r28564. It's good that we didn't remove getViewFromFrame() since the future of web_frame_get_web_view() is uncertain. Thanks!
Note You need to log in before you can comment on or make changes to this bug.