Bug 163456

Summary:

prepare-ChangeLog erroneously said that a python __init__ method was deleted

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, lforschler, mcatanzaro, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch and unit tests	none

Description Simon Fraser (smfr) 2016-10-14 11:31:27 PDT

The patch in https://bugs.webkit.org/attachment.cgi?id=291568 shows:

+        (Reviewer.__init__): Deleted.

even though that patch did not delete it.

Comment 1 Daniel Bates 2016-10-14 16:02:42 PDT

Created attachment 291676 [details]
Patch and unit tests

Comment 2 Daniel Bates 2016-10-15 15:06:48 PDT

Comment on attachment 291676 [details]
Patch and unit tests

Clearing flags on attachment: 291676

Committed r207382: <http://trac.webkit.org/changeset/207382>

Comment 3 Daniel Bates 2016-10-15 15:06:54 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Michael Catanzaro 2016-10-16 17:05:58 PDT

It introduced a Perl warning, can you fix it please?

"my" variable @afterChangeFunctionRanges masks earlier declaration in same scope at /home/mcatanzaro/src/WebKit/Tools/Scripts/prepare-ChangeLog line 359.

Comment 5 Daniel Bates 2016-10-16 20:06:16 PDT

(In reply to comment #4)
> It introduced a Perl warning, can you fix it please?
> 
> "my" variable @afterChangeFunctionRanges masks earlier declaration in same
> scope at /home/mcatanzaro/src/WebKit/Tools/Scripts/prepare-ChangeLog line
> 359.

Fixed in <http://trac.webkit.org/changeset/207399>.