Bug 163451

Summary: [CMake] Private/unsupported build options should be marked as advanced
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2016-10-14 09:56:58 PDT
Private/unsupported build options should be marked as advanced so that they are hidden to users listing CMake options (e.g. with 'cmake -L').
Attachments
Patch (1.48 KB, patch)
2016-10-14 10:30 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-10-14 09:57:54 PDT
Er wait, we already have code for this (WebKitFeatures.cmake): option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}}) if (NOT _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name}) mark_as_advanced(FORCE ${_name}) endif ()
Michael Catanzaro
Comment 2 2016-10-14 10:30:02 PDT
Created attachment 291645 [details] Patch
WebKit Commit Bot
Comment 3 2016-10-14 11:31:54 PDT
Comment on attachment 291645 [details] Patch Clearing flags on attachment: 291645 Committed r207351: <http://trac.webkit.org/changeset/207351>
WebKit Commit Bot
Comment 4 2016-10-14 11:31:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.