Summary: | [CMake] Private/unsupported build options should be marked as advanced | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKit Misc. | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, bugs-noreply, commit-queue, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2016-10-14 09:56:58 PDT
Er wait, we already have code for this (WebKitFeatures.cmake): option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}}) if (NOT _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name}) mark_as_advanced(FORCE ${_name}) endif () Created attachment 291645 [details]
Patch
Comment on attachment 291645 [details] Patch Clearing flags on attachment: 291645 Committed r207351: <http://trac.webkit.org/changeset/207351> All reviewed patches have been landed. Closing bug. |