Bug 163441

Summary: resolve-ChangeLogs: Specify --no-page to git diff
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ddkilzer, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2016-10-14 02:52:30 PDT
resolve-ChangeLogs shows the result after resolving by invoking
'git diff'. It runs a pager for every ChangeLog if it is under
TTY.
Comment 1 Fujii Hironori 2016-10-14 02:57:13 PDT
Created attachment 291605 [details]
Patch
Comment 2 Darin Adler 2016-10-17 10:45:47 PDT
Comment on attachment 291605 [details]
Patch

Sorry, could you explain why this is an improvement? If I am running this script from the TTY, why wouldn’t I want the diff paged?
Comment 3 Darin Adler 2016-10-17 10:46:24 PDT
I guess maybe because it’s multiple diffs and we want to look at them all in a row?
Comment 4 Darin Adler 2016-10-17 10:47:54 PDT
Comment on attachment 291605 [details]
Patch

OK, I thought it through and I guess this is fine.
Comment 5 WebKit Commit Bot 2016-10-17 11:01:57 PDT
Comment on attachment 291605 [details]
Patch

Clearing flags on attachment: 291605

Committed r207416: <http://trac.webkit.org/changeset/207416>
Comment 6 WebKit Commit Bot 2016-10-17 11:02:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Fujii Hironori 2016-10-17 19:38:27 PDT
Thank you for reviewing my patch.

After this change, it outputs like following:

>  $ ./Tools/Scripts/resolve-ChangeLogs
> M	ChangeLog
> M	Source/WebCore/ChangeLog
> M	Tools/ChangeLog

But, without this change, Pager was invoked three times because of
three ChangeLog files resolved.