Bug 163418

Summary: Move BackForwardList from WebCore to WebKitLegacy
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Description Anders Carlsson 2016-10-13 16:30:35 PDT 
Move BackForwardList from WebCore to WebKitLegacy
Comment 1 Anders Carlsson 2016-10-13 16:34:29 PDT 
Created attachment 291535 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-13 16:37:11 PDT 
Attachment 291535 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/History/BackForwardList.mm:97:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:100:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:145:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:209:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardListInternal.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2016-10-13 16:43:21 PDT 
Created attachment 291537 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-13 16:44:50 PDT 
Attachment 291537 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/History/BackForwardList.mm:97:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:100:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:145:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:209:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardListInternal.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Carlsson 2016-10-13 16:50:55 PDT 
Created attachment 291538 [details]
Patch
Comment 6 WebKit Commit Bot 2016-10-13 16:53:36 PDT 
Attachment 291538 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/History/BackForwardList.mm:27:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:144:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:208:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardListInternal.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2016-10-14 10:17:19 PDT 
Committed r207345: <http://trac.webkit.org/changeset/207345>