Bug 163410

Summary: Delete the animated image catchup code
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 155322, 161566    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2016-10-13 15:30:34 PDT
If drawing an image frame took more its duration, we need to fire the timer for the next frame immediately.
Attachments
Patch (16.72 KB, patch)
2016-10-13 15:31 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (16.73 KB, patch)
2016-10-13 15:36 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (22.69 KB, patch)
2016-10-14 19:23 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (20.00 KB, patch)
2016-10-15 13:46 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2016-10-13 15:31:27 PDT
Created attachment 291527 [details] Patch
Said Abou-Hallawa
Comment 2 2016-10-13 15:36:33 PDT
Created attachment 291529 [details] Patch
Said Abou-Hallawa
Comment 3 2016-10-13 18:25:10 PDT
Comment on attachment 291529 [details] Patch I am working on a test.
Said Abou-Hallawa
Comment 4 2016-10-14 19:23:34 PDT
Created attachment 291700 [details] Patch
Simon Fraser (smfr)
Comment 5 2016-10-14 22:58:15 PDT
Comment on attachment 291700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291700&action=review > Source/WebCore/ChangeLog:8 > + Test: fast/images/ordered-animated-image-frames.html Move this line down below the description of the changes (to line 32-ish). > Source/WebCore/ChangeLog:18 > + passed the next_frame_desired_time. In this case we should fire the timer passed -> past > Source/WebCore/ChangeLog:31 > + (k - 1) decoded. You can also justify this removal by the fact that it was never used on iOS.
Said Abou-Hallawa
Comment 6 2016-10-15 13:46:06 PDT
Created attachment 291724 [details] Patch
WebKit Commit Bot
Comment 7 2016-10-15 17:22:01 PDT
Comment on attachment 291724 [details] Patch Clearing flags on attachment: 291724 Committed r207386: <http://trac.webkit.org/changeset/207386>
WebKit Commit Bot
Comment 8 2016-10-15 17:22:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.