Bug 163400

Summary: Web Inspector: Cleanup parts of DebuggerManager
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix timothy: review+

Joseph Pecoraro
Reported 2016-10-13 12:53:52 PDT
Summary: Cleanup parts of DebuggerManager - public methods are all over the place, can be much better grouped - modernize some uses of let/for loops - declare all members in constructor (for clarity) - some public methods have unused features (addBreakpoint)
Attachments
[PATCH] Proposed Fix (26.33 KB, patch)
2016-10-13 12:58 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (26.32 KB, patch)
2016-10-13 13:01 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-10-13 12:58:34 PDT
Created attachment 291506 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2016-10-13 13:01:50 PDT
Created attachment 291507 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-10-13 13:41:57 PDT
This doesn't apply because of other patches still out for review.
Joseph Pecoraro
Comment 4 2016-10-15 00:25:12 PDT
<https://trac.webkit.org/changeset/207371>
Note You need to log in before you can comment on or make changes to this bug.