Bug 163400

Summary: Web Inspector: Cleanup parts of DebuggerManager
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix timothy: review+

Description Joseph Pecoraro 2016-10-13 12:53:52 PDT
Summary:
Cleanup parts of DebuggerManager

  - public methods are all over the place, can be much better grouped
  - modernize some uses of let/for loops
  - declare all members in constructor (for clarity)
  - some public methods have unused features (addBreakpoint)
Comment 1 Joseph Pecoraro 2016-10-13 12:58:34 PDT
Created attachment 291506 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-10-13 13:01:50 PDT
Created attachment 291507 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-10-13 13:41:57 PDT
This doesn't apply because of other patches still out for review.
Comment 4 Joseph Pecoraro 2016-10-15 00:25:12 PDT
<https://trac.webkit.org/changeset/207371>