Bug 163397

Summary: Disable URLParser for non-Safari iOS and Mac apps for now
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163373
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2016-10-13 11:43:13 PDT
Disable URLParser for non-Safari iOS and Mac apps for now
Attachments
Patch (10.89 KB, patch)
2016-10-13 11:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2016-10-13 13:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (12.31 KB, patch)
2016-10-13 13:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-10-13 11:45:13 PDT
Created attachment 291500 [details] Patch
Alex Christensen
Comment 2 2016-10-13 12:00:14 PDT
http://trac.webkit.org/changeset/207297
Ryan Haddad
Comment 3 2016-10-13 12:13:27 PDT
This change broke the iOS build https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20(Build)/builds/906
Ryan Haddad
Comment 4 2016-10-13 12:18:49 PDT
(In reply to comment #3) > This change broke the iOS build > https://build.webkit.org/builders/ > Apple%20iOS%2010%20Simulator%20Release%20(Build)/builds/906 EWS caught this before the patch was landed :(
Ryan Haddad
Comment 5 2016-10-13 12:24:14 PDT
Reverted r207297 for reason: This change broke the iOS build. Committed r207301: <http://trac.webkit.org/changeset/207301>
Alex Christensen
Comment 6 2016-10-13 13:29:48 PDT
Created attachment 291511 [details] Patch
Alex Christensen
Comment 7 2016-10-13 13:54:19 PDT
Created attachment 291513 [details] Patch
Alex Christensen
Comment 8 2016-10-13 14:05:06 PDT
http://trac.webkit.org/changeset/207305
Alex Christensen
Comment 9 2016-10-13 16:41:45 PDT
Fixed tests in r207315
Note You need to log in before you can comment on or make changes to this bug.