Bug 163397 - Disable URLParser for non-Safari iOS and Mac apps for now
Summary: Disable URLParser for non-Safari iOS and Mac apps for now
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-13 11:43 PDT by Alex Christensen
Modified: 2016-10-13 16:41 PDT (History)
1 user (show)

See Also:

Attachments
Patch (10.89 KB, patch)
2016-10-13 11:45 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.25 KB, patch)
2016-10-13 13:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.31 KB, patch)
2016-10-13 13:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-10-13 11:43:13 PDT 
Disable URLParser for non-Safari iOS and Mac apps for now
Comment 1 Alex Christensen 2016-10-13 11:45:13 PDT 
Created attachment 291500 [details]
Patch
Comment 2 Alex Christensen 2016-10-13 12:00:14 PDT 
http://trac.webkit.org/changeset/207297
Comment 3 Ryan Haddad 2016-10-13 12:13:27 PDT 
This change broke the iOS build https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20(Build)/builds/906
Comment 4 Ryan Haddad 2016-10-13 12:18:49 PDT 
(In reply to comment #3)
> This change broke the iOS build
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Release%20(Build)/builds/906

EWS caught this before the patch was landed :(
Comment 5 Ryan Haddad 2016-10-13 12:24:14 PDT 
Reverted r207297 for reason:

This change broke the iOS build.

Committed r207301: <http://trac.webkit.org/changeset/207301>
Comment 6 Alex Christensen 2016-10-13 13:29:48 PDT 
Created attachment 291511 [details]
Patch
Comment 7 Alex Christensen 2016-10-13 13:54:19 PDT 
Created attachment 291513 [details]
Patch
Comment 8 Alex Christensen 2016-10-13 14:05:06 PDT 
http://trac.webkit.org/changeset/207305
Comment 9 Alex Christensen 2016-10-13 16:41:45 PDT 
Fixed tests in r207315