Bug 163369

Summary:

Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event]

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none

Chris Dumez

Reported 2016-10-12 16:54:24 PDT

Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.

Attachments
Patch (13.89 KB, patch) 2016-10-12 16:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (18.15 KB, patch) 2016-10-12 19:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (8.87 MB, application/zip) 2016-10-12 20:26 PDT, Build Bot	no flags	Details
Patch (19.60 KB, patch) 2016-10-12 20:38 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-10-12 16:56:30 PDT

Created attachment 291422 [details] Patch

Chris Dumez

Comment 2 2016-10-12 19:08:56 PDT

Created attachment 291439 [details] Patch

Chris Dumez

Comment 3 2016-10-12 19:48:20 PDT

Comment on attachment 291439 [details] Patch Looks like my new test fails in debug. I'll investigate.

Build Bot

Comment 4 2016-10-12 20:25:56 PDT

Comment on attachment 291439 [details] Patch Attachment 291439 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2274231 New failing tests: fast/events/webkit-media-key-events-constructor.html

Build Bot

Comment 5 2016-10-12 20:26:00 PDT

Created attachment 291446 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 6 2016-10-12 20:38:41 PDT

Created attachment 291448 [details] Patch

WebKit Commit Bot

Comment 7 2016-10-12 22:21:39 PDT

Comment on attachment 291448 [details] Patch Clearing flags on attachment: 291448 Committed r207277: <http://trac.webkit.org/changeset/207277>

WebKit Commit Bot

Comment 8 2016-10-12 22:21:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.