Bug 163369

Summary: Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch none

Description Chris Dumez 2016-10-12 16:54:24 PDT
Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Comment 1 Chris Dumez 2016-10-12 16:56:30 PDT
Created attachment 291422 [details]
Patch
Comment 2 Chris Dumez 2016-10-12 19:08:56 PDT
Created attachment 291439 [details]
Patch
Comment 3 Chris Dumez 2016-10-12 19:48:20 PDT
Comment on attachment 291439 [details]
Patch

Looks like my new test fails in debug. I'll investigate.
Comment 4 Build Bot 2016-10-12 20:25:56 PDT
Comment on attachment 291439 [details]
Patch

Attachment 291439 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2274231

New failing tests:
fast/events/webkit-media-key-events-constructor.html
Comment 5 Build Bot 2016-10-12 20:26:00 PDT
Created attachment 291446 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Chris Dumez 2016-10-12 20:38:41 PDT
Created attachment 291448 [details]
Patch
Comment 7 WebKit Commit Bot 2016-10-12 22:21:39 PDT
Comment on attachment 291448 [details]
Patch

Clearing flags on attachment: 291448

Committed r207277: <http://trac.webkit.org/changeset/207277>
Comment 8 WebKit Commit Bot 2016-10-12 22:21:44 PDT
All reviewed patches have been landed.  Closing bug.