Bug 163358

Summary:

Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, darin, rniwa, sam, tkent

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

163296

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2016-10-12 14:18:37 PDT

Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements. As per the specification, we only want optgroup elements that are direct children of the select element.

Attachments
Patch (4.61 KB, patch) 2016-10-12 15:48 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-10-12 15:35:47 PDT

test case: https://jsfiddle.net/varkv40b/10/

Chris Dumez

Comment 2 2016-10-12 15:40:44 PDT

(In reply to comment #1) > test case: > https://jsfiddle.net/varkv40b/10/ Better: https://jsfiddle.net/varkv40b/16/

Chris Dumez

Comment 3 2016-10-12 15:48:33 PDT

Created attachment 291410 [details] Patch

WebKit Commit Bot

Comment 4 2016-10-12 21:16:26 PDT

Comment on attachment 291410 [details] Patch Clearing flags on attachment: 291410 Committed r207276: <http://trac.webkit.org/changeset/207276>

WebKit Commit Bot

Comment 5 2016-10-12 21:16:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.