Bug 163352

Summary: [Web IDL] Generated bindings include the wrong header when ImplementedAs is used on a dictionary
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, darin, esprehn+autocc, jiewen_tan, kondapallykalyan, rniwa, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-10-12 13:31:25 PDT
Generated bindings include the wrong header when ImplementedAs is used on a dictionary.
Attachments
Patch (5.64 KB, patch)
2016-10-12 13:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-12 13:33:30 PDT
Created attachment 291388 [details] Patch
Jiewen Tan
Comment 2 2016-10-12 13:37:51 PDT
Comment on attachment 291388 [details] Patch Thanks Chris for making this fix so quickly. Will it be good to keep the old TestStandaloneDictionary test case as well?
WebKit Commit Bot
Comment 3 2016-10-12 14:12:23 PDT
Comment on attachment 291388 [details] Patch Clearing flags on attachment: 291388 Committed r207243: <http://trac.webkit.org/changeset/207243>
WebKit Commit Bot
Comment 4 2016-10-12 14:12:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.