Bug 163352 - [Web IDL] Generated bindings include the wrong header when ImplementedAs is used on a dictionary
Summary: [Web IDL] Generated bindings include the wrong header when ImplementedAs is u...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 13:31 PDT by Chris Dumez
Modified: 2016-10-12 14:12 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.64 KB, patch)
2016-10-12 13:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-12 13:31:25 PDT 
Generated bindings include the wrong header when ImplementedAs is used on a dictionary.
Comment 1 Chris Dumez 2016-10-12 13:33:30 PDT 
Created attachment 291388 [details]
Patch
Comment 2 Jiewen Tan 2016-10-12 13:37:51 PDT 
Comment on attachment 291388 [details]
Patch

Thanks Chris for making this fix so quickly. Will it be good to keep the old TestStandaloneDictionary test case as well?
Comment 3 WebKit Commit Bot 2016-10-12 14:12:23 PDT 
Comment on attachment 291388 [details]
Patch

Clearing flags on attachment: 291388

Committed r207243: <http://trac.webkit.org/changeset/207243>
Comment 4 WebKit Commit Bot 2016-10-12 14:12:28 PDT 
All reviewed patches have been landed.  Closing bug.