Bug 163347

Summary: Make Document::existingAXObjectCache() fast with accessibility disabled.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2016-10-12 11:34:08 PDT 
We're spending 2.3% of a Dromaeo/dom-modify.html profile in here and that seems avoidable.
Comment 1 Andreas Kling 2016-10-12 11:34:55 PDT 
Created attachment 291374 [details]
Patch
Comment 2 Antti Koivisto 2016-10-12 12:15:40 PDT 
Comment on attachment 291374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291374&action=review

> Source/WebCore/dom/Document.cpp:2430
> +static bool hasEverCreatedAnAXObjectCache = false;

I suppose this works fine in practice (ax being an on/off thing) though in principle this sort of global one-way penalty boxes are somewhat nasty.
Comment 3 WebKit Commit Bot 2016-10-12 12:38:32 PDT 
Comment on attachment 291374 [details]
Patch

Clearing flags on attachment: 291374

Committed r207234: <http://trac.webkit.org/changeset/207234>
Comment 4 WebKit Commit Bot 2016-10-12 12:38:37 PDT 
All reviewed patches have been landed.  Closing bug.