Bug 163347

Summary: Make Document::existingAXObjectCache() fast with accessibility disabled.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2016-10-12 11:34:08 PDT
We're spending 2.3% of a Dromaeo/dom-modify.html profile in here and that seems avoidable.
Attachments
Patch (1.84 KB, patch)
2016-10-12 11:34 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-10-12 11:34:55 PDT
Created attachment 291374 [details] Patch
Antti Koivisto
Comment 2 2016-10-12 12:15:40 PDT
Comment on attachment 291374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291374&action=review > Source/WebCore/dom/Document.cpp:2430 > +static bool hasEverCreatedAnAXObjectCache = false; I suppose this works fine in practice (ax being an on/off thing) though in principle this sort of global one-way penalty boxes are somewhat nasty.
WebKit Commit Bot
Comment 3 2016-10-12 12:38:32 PDT
Comment on attachment 291374 [details] Patch Clearing flags on attachment: 291374 Committed r207234: <http://trac.webkit.org/changeset/207234>
WebKit Commit Bot
Comment 4 2016-10-12 12:38:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.