Bug 163331

Summary: [Win] Encode function pointers.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191960
Attachments:
Description Flags
Patch bfulgham: review+, bfulgham: commit-queue-

Description Per Arne Vollan 2016-10-12 07:38:13 PDT 
For security reasons, we should encode stored function pointers.
Comment 1 Per Arne Vollan 2016-10-12 07:43:54 PDT 
Created attachment 291356 [details]
Patch
Comment 2 Per Arne Vollan 2016-10-12 07:54:45 PDT 
<rdar://problem/9915523>
Comment 3 Alex Christensen 2016-10-12 08:25:54 PDT 
Comment on attachment 291356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291356&action=review

> Source/WebCore/platform/win/SoftLinking.h:-105
> -    static resultType callingConvention init##functionName parameterDeclarations \

Are these unit functions no longer needed?
Comment 4 Per Arne Vollan 2016-10-12 10:42:56 PDT 
(In reply to comment #3)
> Comment on attachment 291356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291356&action=review
> 
> > Source/WebCore/platform/win/SoftLinking.h:-105
> > -    static resultType callingConvention init##functionName parameterDeclarations \
> 
> Are these unit functions no longer needed?

No, these should not be needed anymore. The function pointer will be initialized the first time the function is called.

Thanks for reviewing!
Comment 5 Brent Fulgham 2016-10-12 22:36:31 PDT 
Comment on attachment 291356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291356&action=review

r=me.

>>> Source/WebCore/platform/win/SoftLinking.h:-105
>>> -    static resultType callingConvention init##functionName parameterDeclarations \
>> 
>> Are these unit functions no longer needed?
> 
> No, these should not be needed anymore. The function pointer will be initialized the first time the function is called.
> 
> Thanks for reviewing!

r=me if you remove the unneeded functions!
Comment 6 Per Arne Vollan 2016-10-13 05:00:57 PDT 
Committed r207282: <http://trac.webkit.org/changeset/207282>