Bug 163329

Summary: [Readable Streams API] Cleanup patch, fix small inconsistencies
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, youennf
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Romain Bellessort
Reported 2016-10-12 05:48:09 PDT
After comparing spec and implementation, 3 small fixes should be done: - add optional parameter in ReadableStream getReader IDL; - add missing ASSERT in readableStreamDefaultControllerCallPullIfNeeded; - call readableStreamDefaultControllerError instead of readableStreamError in ReadableStreamDefaultController error method.
Attachments
Patch (3.07 KB, patch)
2016-10-12 05:58 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-10-12 05:58:22 PDT
Created attachment 291352 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-14 07:12:23 PDT
Comment on attachment 291352 [details] Patch Clearing flags on attachment: 291352 Committed r207337: <http://trac.webkit.org/changeset/207337>
WebKit Commit Bot
Comment 3 2016-10-14 07:12:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.