Bug 163329 - [Readable Streams API] Cleanup patch, fix small inconsistencies
Summary: [Readable Streams API] Cleanup patch, fix small inconsistencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Romain Bellessort
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 05:48 PDT by Romain Bellessort
Modified: 2016-10-14 07:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2016-10-12 05:58 PDT, Romain Bellessort
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-10-12 05:48:09 PDT
After comparing spec and implementation, 3 small fixes should be done:
- add optional parameter in ReadableStream getReader IDL;
- add missing ASSERT in readableStreamDefaultControllerCallPullIfNeeded;
- call readableStreamDefaultControllerError instead of readableStreamError in ReadableStreamDefaultController error method.
Comment 1 Romain Bellessort 2016-10-12 05:58:22 PDT
Created attachment 291352 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-14 07:12:23 PDT
Comment on attachment 291352 [details]
Patch

Clearing flags on attachment: 291352

Committed r207337: <http://trac.webkit.org/changeset/207337>
Comment 3 WebKit Commit Bot 2016-10-14 07:12:30 PDT
All reviewed patches have been landed.  Closing bug.