Bug 163326

Summary:

Binding generated code for private operations should assert for casted-this checks

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cgarcia, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2016-10-12 03:05:28 PDT

Private operations can only be called by WebKit code.
Since we control the call sites, the call sites should make sure to call the operations with the object of the right type.

Comment 1 youenn fablet 2016-10-12 03:21:47 PDT

Created attachment 291348 [details]
Patch

Comment 2 youenn fablet 2016-10-12 08:42:26 PDT

(In reply to comment #1)
> Created attachment 291348 [details]
> Patch

This patch makes sense from a technical point of view.
But it requires to be careful on call sites.
I am wondering whether it will not be too easy to miss the necessary check on call sites.

Comment 3 WebKit Commit Bot 2016-10-14 00:01:06 PDT

Comment on attachment 291348 [details]
Patch

Clearing flags on attachment: 291348

Committed r207328: <http://trac.webkit.org/changeset/207328>

Comment 4 WebKit Commit Bot 2016-10-14 00:01:10 PDT

All reviewed patches have been landed.  Closing bug.