Bug 163325

Summary: Update serializer and iterator binding generated code
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, cdumez, cgarcia, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2016-10-12 02:59:22 PDT
Serializer can use the direct attribute getter functions. Serializer and iterator operations can use BindingCaller::callOperation.
Attachments
Patch (21.86 KB, patch)
2016-10-12 03:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (21.89 KB, patch)
2016-10-12 04:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-10-12 03:03:12 PDT
Created attachment 291347 [details] Patch
youenn fablet
Comment 2 2016-10-12 04:19:52 PDT
Created attachment 291349 [details] Patch
Darin Adler
Comment 3 2016-10-12 09:21:50 PDT
Comment on attachment 291349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291349&action=review > Source/WebCore/bindings/js/JSDOMIterator.h:135 > + JSDOMGlobalObject& globalObject = *thisObject.globalObject(); I suggest auto& here instead of naming a type. > Source/WebCore/bindings/js/JSDOMIterator.h:197 > break; I think it would be better to do "return { };" here instead of break.
WebKit Commit Bot
Comment 4 2016-10-13 23:21:50 PDT
Comment on attachment 291349 [details] Patch Clearing flags on attachment: 291349 Committed r207324: <http://trac.webkit.org/changeset/207324>
WebKit Commit Bot
Comment 5 2016-10-13 23:21:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.