Bug 163325 - Update serializer and iterator binding generated code
Summary: Update serializer and iterator binding generated code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 02:59 PDT by youenn fablet
Modified: 2016-10-13 23:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (21.86 KB, patch)
2016-10-12 03:03 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (21.89 KB, patch)
2016-10-12 04:19 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-12 02:59:22 PDT
Serializer can use the direct attribute getter functions.
Serializer and iterator operations can use BindingCaller::callOperation.
Comment 1 youenn fablet 2016-10-12 03:03:12 PDT
Created attachment 291347 [details]
Patch
Comment 2 youenn fablet 2016-10-12 04:19:52 PDT
Created attachment 291349 [details]
Patch
Comment 3 Darin Adler 2016-10-12 09:21:50 PDT
Comment on attachment 291349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291349&action=review

> Source/WebCore/bindings/js/JSDOMIterator.h:135
> +    JSDOMGlobalObject& globalObject = *thisObject.globalObject();

I suggest auto& here instead of naming a type.

> Source/WebCore/bindings/js/JSDOMIterator.h:197
>              break;

I think it would be better to do "return { };" here instead of break.
Comment 4 WebKit Commit Bot 2016-10-13 23:21:50 PDT
Comment on attachment 291349 [details]
Patch

Clearing flags on attachment: 291349

Committed r207324: <http://trac.webkit.org/changeset/207324>
Comment 5 WebKit Commit Bot 2016-10-13 23:21:55 PDT
All reviewed patches have been landed.  Closing bug.