Bug 163319

Summary: Update remaining DOM events to stop using legacy [ConstructorTemplate=Event]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-10-11 22:19:13 PDT
Update remaining DOM events to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Attachments
Patch (101.03 KB, patch)
2016-10-11 22:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-11 22:26:37 PDT
Created attachment 291333 [details] Patch
Darin Adler
Comment 2 2016-10-12 09:18:46 PDT
Comment on attachment 291333 [details] Patch Unclear to me how we get test coverage for the cases where the defaults in IDL don’t match the defaults inside the header file. Also not sure why exactly we need defaults in the header file; for example we don’t have them for any of the JSValue cases.
Chris Dumez
Comment 3 2016-10-12 09:25:38 PDT
Comment on attachment 291333 [details] Patch Clearing flags on attachment: 291333 Committed r207215: <http://trac.webkit.org/changeset/207215>
Chris Dumez
Comment 4 2016-10-12 09:25:43 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2016-10-12 09:30:45 PDT
(In reply to comment #2) > Comment on attachment 291333 [details] > Patch > > Unclear to me how we get test coverage for the cases where the defaults in > IDL don’t match the defaults inside the header file. Also not sure why > exactly we need defaults in the header file; for example we don’t have them > for any of the JSValue cases. The default values in the struct have actually no impact if the struct is used from bindings code because the generated bindings code will overwrite each member with whatever default value is defined in the IDL. The only use for those default values is in case the struct is used from implementation, which is uncommon (but is done in a few places).
Note You need to log in before you can comment on or make changes to this bug.