Bug 163275

Summary: Attribute setter binding generated code should use more references
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, cgarcia, commit-queue, darin, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-10-11 05:32:55 PDT
Attribute setter binding generated code should use more references
Attachments
Patch (149.25 KB, patch)
2016-10-11 05:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (155.46 KB, patch)
2016-10-12 00:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-10-11 05:38:25 PDT
Created attachment 291249 [details] Patch
Alex Christensen
Comment 2 2016-10-11 08:10:57 PDT
Comment on attachment 291249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291249&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4935 > + # FIXME: Remove these 3 variables while all JSValueToNative use references. when
youenn fablet
Comment 3 2016-10-12 00:05:13 PDT
Created attachment 291342 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-10-12 00:39:53 PDT
Comment on attachment 291342 [details] Patch for landing Clearing flags on attachment: 291342 Committed r207193: <http://trac.webkit.org/changeset/207193>
WebKit Commit Bot
Comment 5 2016-10-12 00:39:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.