Summary: | Update IDBVersionChangeEvent to stop using legacy [ConstructorTemplate=Event] | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | alecflett, beidson, buildbot, cdumez, cgarcia, commit-queue, darin, esprehn+autocc, jsbell, kondapallykalyan, rniwa, sam | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2016-10-10 21:20:13 PDT
Created attachment 291230 [details]
Patch
Comment on attachment 291230 [details] Patch Attachment 291230 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2260325 New failing tests: storage/indexeddb/modern/idbversionchangeevent-constructor.html Created attachment 291234 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291230 [details] Patch Attachment 291230 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2260415 New failing tests: storage/indexeddb/modern/idbversionchangeevent-constructor.html Created attachment 291235 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 291230 [details] Patch Attachment 291230 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2260414 New failing tests: storage/indexeddb/modern/idbversionchangeevent-constructor.html Created attachment 291236 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 291237 [details]
Patch
Comment on attachment 291237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291237&action=review > Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl:37 > + unsigned long long oldVersion = 0; I don’t think we should have the two spaces here. Created attachment 291239 [details]
Patch
Comment on attachment 291239 [details] Patch Clearing flags on attachment: 291239 Committed r207058: <http://trac.webkit.org/changeset/207058> All reviewed patches have been landed. Closing bug. |