Summary: | Update my name in contributors.json | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Theresa O'Connor <eoconnor> | ||||||||
Component: | Tools / Tests | Assignee: | Theresa O'Connor <eoconnor> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, glenn, lforschler, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Theresa O'Connor
2016-10-10 16:18:12 PDT
Created attachment 291179 [details]
Update my name in contributors.json
Changed my name in contributors.json.
Moved old name to be an alias.
Attachment 291179 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5]
Total errors found: 1 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 291179 [details] Update my name in contributors.json View in context: https://bugs.webkit.org/attachment.cgi?id=291179&action=review > Tools/Scripts/webkitpy/common/config/contributors.json:5139 > + "Edward O'Connor" You should add "Tess O'Connor" here too. Created attachment 291189 [details]
Patch
Attachment 291189 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5]
Total errors found: 1 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 291189 [details] Patch Rejecting attachment 291189 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291189, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 207033 = e09428a719bbf7d656fe7c55276924f43f28208e r207034 = 030126092e4957504a33f3fbb6f4dca6775f622e r207035 = f0ad2cd43a4296421030530127dd35431937ec00 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2258809 All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Created attachment 291290 [details]
Patch
Attachment 291290 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 291290 [details] Patch Clearing flags on attachment: 291290 Committed r207161: <http://trac.webkit.org/changeset/207161> All reviewed patches have been landed. Closing bug. |