Bug 163251 - Update my name in contributors.json
Summary: Update my name in contributors.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Theresa O'Connor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 16:18 PDT by Theresa O'Connor
Modified: 2016-10-11 13:26 PDT (History)
4 users (show)

See Also:


Attachments
Update my name in contributors.json (918 bytes, patch)
2016-10-10 16:19 PDT, Theresa O'Connor
no flags Details | Formatted Diff | Diff
Patch (971 bytes, patch)
2016-10-10 16:57 PDT, Theresa O'Connor
no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2016-10-11 12:45 PDT, Theresa O'Connor
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Theresa O'Connor 2016-10-10 16:18:12 PDT
I should update my name in contributors.json.
Comment 1 Theresa O'Connor 2016-10-10 16:19:44 PDT
Created attachment 291179 [details]
Update my name in contributors.json

Changed my name in contributors.json.
Moved old name to be an alias.
Comment 2 WebKit Commit Bot 2016-10-10 16:22:28 PDT
Attachment 291179 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2016-10-10 16:52:53 PDT
Comment on attachment 291179 [details]
Update my name in contributors.json

View in context: https://bugs.webkit.org/attachment.cgi?id=291179&action=review

> Tools/Scripts/webkitpy/common/config/contributors.json:5139
> +         "Edward O'Connor"

You should add "Tess O'Connor" here too.
Comment 4 Theresa O'Connor 2016-10-10 16:57:28 PDT
Created attachment 291189 [details]
Patch
Comment 5 WebKit Commit Bot 2016-10-10 16:59:37 PDT
Attachment 291189 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2016-10-10 17:21:46 PDT
Comment on attachment 291189 [details]
Patch

Rejecting attachment 291189 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291189, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 207033 = e09428a719bbf7d656fe7c55276924f43f28208e
r207034 = 030126092e4957504a33f3fbb6f4dca6775f622e
r207035 = f0ad2cd43a4296421030530127dd35431937ec00
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2258809
Comment 7 Simon Fraser (smfr) 2016-10-11 08:10:58 PDT
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Comment 8 Theresa O'Connor 2016-10-11 12:45:42 PDT
Created attachment 291290 [details]
Patch
Comment 9 WebKit Commit Bot 2016-10-11 12:48:46 PDT
Attachment 291290 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2016-10-11 13:26:23 PDT
Comment on attachment 291290 [details]
Patch

Clearing flags on attachment: 291290

Committed r207161: <http://trac.webkit.org/changeset/207161>
Comment 11 WebKit Commit Bot 2016-10-11 13:26:27 PDT
All reviewed patches have been landed.  Closing bug.