Bug 163243

Summary: Update GamepadEvent to stop using legacy [ConstructorTemplate=Event]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, darin, esprehn+autocc, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-10-10 14:41:43 PDT
Update GamepadEvent to stop using legacy [ConstructorTemplate=Event] and use a proper constructor as in the specification: - https://w3c.github.io/gamepad/#gamepadevent-interface
Attachments
Patch (4.15 KB, patch)
2016-10-10 15:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-10 15:26:29 PDT
Created attachment 291174 [details] Patch
Chris Dumez
Comment 2 2016-10-10 16:58:19 PDT
FYI, I am aware that the constructor does not match the specification. It is because the specification is wrong: https://github.com/w3c/gamepad/issues/35
WebKit Commit Bot
Comment 3 2016-10-10 19:58:01 PDT
Comment on attachment 291174 [details] Patch Clearing flags on attachment: 291174 Committed r207038: <http://trac.webkit.org/changeset/207038>
WebKit Commit Bot
Comment 4 2016-10-10 19:58:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.