Bug 163218

Summary: Added override specifier to PluginViewBase::isPluginViewBase()
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebCore Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mcatanzaro, simon.fraser
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-10-10 09:38:51 PDT
Added override specifier to PluginViewBase::isPluginViewBase()
Attachments
Patch (1.69 KB, patch)
2016-10-10 09:43 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (1.36 KB, patch)
2016-10-10 16:27 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-10-10 09:43:23 PDT
Created attachment 291114 [details] Patch
Anders Carlsson
Comment 2 2016-10-10 09:57:15 PDT
Comment on attachment 291114 [details] Patch Sounds good, but please don't move the declaration to the top.
Konstantin Tokarev
Comment 3 2016-10-10 10:04:19 PDT
Move it to bottom or keep in place? I think it's better to separate new virtual APIs from inherited from base class
Konstantin Tokarev
Comment 4 2016-10-10 16:27:44 PDT
Created attachment 291180 [details] Patch
WebKit Commit Bot
Comment 5 2016-10-10 17:02:21 PDT
Comment on attachment 291180 [details] Patch Clearing flags on attachment: 291180 Committed r207034: <http://trac.webkit.org/changeset/207034>
WebKit Commit Bot
Comment 6 2016-10-10 17:02:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.