Bug 163218

Summary: Added override specifier to PluginViewBase::isPluginViewBase()
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebCore Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mcatanzaro, simon.fraser
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Konstantin Tokarev 2016-10-10 09:38:51 PDT 
Added override specifier to PluginViewBase::isPluginViewBase()
Comment 1 Konstantin Tokarev 2016-10-10 09:43:23 PDT 
Created attachment 291114 [details]
Patch
Comment 2 Anders Carlsson 2016-10-10 09:57:15 PDT 
Comment on attachment 291114 [details]
Patch

Sounds good, but please don't move the declaration to the top.
Comment 3 Konstantin Tokarev 2016-10-10 10:04:19 PDT 
Move it to bottom or keep in place? I think it's better to separate new virtual APIs from inherited from base class
Comment 4 Konstantin Tokarev 2016-10-10 16:27:44 PDT 
Created attachment 291180 [details]
Patch
Comment 5 WebKit Commit Bot 2016-10-10 17:02:21 PDT 
Comment on attachment 291180 [details]
Patch

Clearing flags on attachment: 291180

Committed r207034: <http://trac.webkit.org/changeset/207034>
Comment 6 WebKit Commit Bot 2016-10-10 17:02:25 PDT 
All reviewed patches have been landed.  Closing bug.