Bug 163218 - Added override specifier to PluginViewBase::isPluginViewBase()
Summary: Added override specifier to PluginViewBase::isPluginViewBase()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 09:38 PDT by Konstantin Tokarev
Modified: 2016-10-10 17:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2016-10-10 09:43 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2016-10-10 16:27 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-10-10 09:38:51 PDT 
Added override specifier to PluginViewBase::isPluginViewBase()
Comment 1 Konstantin Tokarev 2016-10-10 09:43:23 PDT 
Created attachment 291114 [details]
Patch
Comment 2 Anders Carlsson 2016-10-10 09:57:15 PDT 
Comment on attachment 291114 [details]
Patch

Sounds good, but please don't move the declaration to the top.
Comment 3 Konstantin Tokarev 2016-10-10 10:04:19 PDT 
Move it to bottom or keep in place? I think it's better to separate new virtual APIs from inherited from base class
Comment 4 Konstantin Tokarev 2016-10-10 16:27:44 PDT 
Created attachment 291180 [details]
Patch
Comment 5 WebKit Commit Bot 2016-10-10 17:02:21 PDT 
Comment on attachment 291180 [details]
Patch

Clearing flags on attachment: 291180

Committed r207034: <http://trac.webkit.org/changeset/207034>
Comment 6 WebKit Commit Bot 2016-10-10 17:02:25 PDT 
All reviewed patches have been landed.  Closing bug.