|Summary:||Make validate-committer-lists show inactive reviewers|
|Product:||WebKit||Reporter:||Simon Fraser (smfr) <simon.fraser>|
|Component:||New Bugs||Assignee:||Simon Fraser (smfr) <simon.fraser>|
|Severity:||Normal||CC:||ap, cdumez, commit-queue, glenn, rniwa, sam, simon.fraser, thorton|
|Version:||WebKit Nightly Build|
Description Simon Fraser (smfr) 2016-10-09 21:57:09 PDT
Make validate-committer-lists show inactive reviewers
Comment 2 WebKit Commit Bot 2016-10-09 22:04:05 PDT
Attachment 291061 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax]  Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2016-10-09 22:15:38 PDT
Comment on attachment 291061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291061&action=review > Tools/ChangeLog:12 > + This list is computed by grepping the output of 'git log --since=1.year" for Does this mean it won't work if you have svn? Can we make this work with SVN as well? > Tools/ChangeLog:18 > + Support for aliases is added to Contributor. Aliases are alternates > + or misspellings of the reviewer's name. Some common aliases were added to > + contributors.json by manual examination of "Reviewed by" lines. Can I give myself sweet aliases?
Comment 4 Simon Fraser (smfr) 2016-10-09 22:23:29 PDT
(In reply to comment #3) > Comment on attachment 291061 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291061&action=review > > > Tools/ChangeLog:12 > > + This list is computed by grepping the output of 'git log --since=1.year" for > > Does this mean it won't work if you have svn? Yes. The script already does something like: if not Git.in_working_directory("."): print """\n\nWARNING: validate-committer-lists requires a git checkout. The following checks are disabled: - List of inactive committers - List of inactive reviewers - List of historical committers missing from contributors.json """ return 1 > Can we make this work with SVN as well? Possibly, with extra work, which I don't intend to do.
Comment 6 Sam Weinig 2016-10-09 22:26:10 PDT
> > Can we make this work with SVN as well? > > Possibly, with extra work, which I don't intend to do. I regret my r+ :(. I am really not a fan of tools that don't work in our default configuration. Please please reconsider.
Comment 7 Chris Dumez 2016-10-10 13:15:00 PDT
Bugzilla no longer autocompletes any email. Could this be because of this change?
Comment 8 Simon Fraser (smfr) 2016-10-10 13:16:54 PDT
It works for me. Maybe clear caches?