Bug 163187

Summary: Update MessageEvent to stop using legacy [ConstructorTemplate=Event]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163189    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-10-09 15:26:24 PDT
Update MessageEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor as in the specification: - https://html.spec.whatwg.org/multipage/comms.html#the-messageevent-interfaces
Attachments
Patch (28.08 KB, patch)
2016-10-10 10:21 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (28.60 KB, patch)
2016-10-10 12:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (28.47 KB, patch)
2016-10-10 13:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-10 10:21:44 PDT
Created attachment 291117 [details] Patch
Darin Adler
Comment 2 2016-10-10 12:06:10 PDT
Comment on attachment 291117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291117&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4759 > + return "MessagePortArray" if $innerType eq "MessagePort"; > + return "Vector<" . GetNativeVectorInnerType($innerType) . ">"; This looks peculiar enough that it maybe these rules should be in a separate function. > Source/WebCore/dom/MessageEvent.h:48 > + struct Init : public EventInit { No need for "public" here.
Chris Dumez
Comment 3 2016-10-10 12:41:37 PDT
Created attachment 291143 [details] Patch
Chris Dumez
Comment 4 2016-10-10 13:13:20 PDT
Created attachment 291151 [details] Patch
Chris Dumez
Comment 5 2016-10-10 13:24:05 PDT
Comment on attachment 291151 [details] Patch Clearing flags on attachment: 291151 Committed r207016: <http://trac.webkit.org/changeset/207016>
Chris Dumez
Comment 6 2016-10-10 13:24:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.