Bug 163154

Summary: [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Description Simon Fraser (smfr) 2016-10-07 16:01:51 PDT
[WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
Comment 1 Simon Fraser (smfr) 2016-10-07 16:08:42 PDT
Created attachment 290980 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-07 16:09:51 PDT
Attachment 290980 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebClipView.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2016-10-07 16:10:38 PDT
Created attachment 290981 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-07 16:12:39 PDT
Attachment 290981 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebClipView.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2016-10-07 16:14:06 PDT
Comment on attachment 290980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290980&action=review

> Source/WebKit/mac/WebView/WebClipView.mm:51
>  @interface NSClipView (WebNSClipViewDetails)

Nothing in the () maybe.

> Source/WebKit/mac/WebView/WebHTMLView.mm:4115
> -    if (_private->inScrollPositionChanged) {
> +    if (_private->inScrollPositionChanged && [(WebClipView *)[self superview] currentScrollIsBlit]) {

Maybe check to be safe?
Comment 6 Simon Fraser (smfr) 2016-10-07 17:13:00 PDT
Created attachment 290986 [details]
Patch
Comment 7 WebKit Commit Bot 2016-10-07 17:14:30 PDT
Attachment 290986 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4122:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebClipView.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Tim Horton 2016-10-07 17:15:23 PDT
Comment on attachment 290986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290986&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:4122
> -    if (_private->inScrollPositionChanged) {
> +    if (_private->inScrollPositionChanged

Do not love this wrapping.
Comment 9 Simon Fraser (smfr) 2016-10-07 17:23:12 PDT
https://trac.webkit.org/r206945