Bug 163141

Summary: Move ViewGestureController files to more accurate locations
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2016-10-07 14:06:23 PDT
Move ViewGestureController files to more accurate locations
Attachments
Patch (53.54 KB, patch)
2016-10-07 14:06 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-10-07 14:06:37 PDT
Created attachment 290966 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-07 14:07:51 PDT
Attachment 290966 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:47: _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:48: _UIViewControllerOneToOneTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:49: _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:269: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2016-10-07 14:15:02 PDT
https://trac.webkit.org/changeset/206936
Note You need to log in before you can comment on or make changes to this bug.