Bug 163094

Summary: AX: AXRoleDescription for details and summary elements
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, n_wang, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

Nan Wang
Reported 2016-10-06 17:28:35 PDT
details and summary elements should have AXRoleDescription that is consistent with other elements that have custom AXSubRole. Expected: AXGroup/AXDetails/details group AXGroup/AXSummary/summary group <rdar://problem/26638751>
Attachments
patch (8.47 KB, patch)
2016-10-06 17:34 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (8.46 KB, patch)
2016-10-06 23:03 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (8.38 KB, patch)
2016-10-06 23:48 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nan Wang
Comment 1 2016-10-06 17:34:07 PDT
Created attachment 290876 [details] patch
Nan Wang
Comment 2 2016-10-06 23:03:23 PDT
Created attachment 290900 [details] patch fixed Efl build failure.
chris fleizach
Comment 3 2016-10-06 23:20:47 PDT
Comment on attachment 290900 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=290900&action=review > Source/WebCore/English.lproj/Localizable.strings:815 > +"details group" = "details group"; don't think we need to add "group" in this string, since it's AXRole is a group
Nan Wang
Comment 4 2016-10-06 23:48:41 PDT
Created attachment 290904 [details] patch updated the string.
WebKit Commit Bot
Comment 5 2016-10-07 10:47:22 PDT
Comment on attachment 290904 [details] patch Clearing flags on attachment: 290904 Committed r206921: <http://trac.webkit.org/changeset/206921>
WebKit Commit Bot
Comment 6 2016-10-07 10:47:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.