Bug 163094

Summary: AX: AXRoleDescription for details and summary elements
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, n_wang, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Nan Wang 2016-10-06 17:28:35 PDT 
details and summary elements should have AXRoleDescription that is consistent with other elements that have custom AXSubRole.

Expected:
AXGroup/AXDetails/details group
AXGroup/AXSummary/summary group

<rdar://problem/26638751>
Comment 1 Nan Wang 2016-10-06 17:34:07 PDT 
Created attachment 290876 [details]
patch
Comment 2 Nan Wang 2016-10-06 23:03:23 PDT 
Created attachment 290900 [details]
patch

fixed Efl build failure.
Comment 3 chris fleizach 2016-10-06 23:20:47 PDT 
Comment on attachment 290900 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290900&action=review

> Source/WebCore/English.lproj/Localizable.strings:815
> +"details group" = "details group";

don't think we need to add "group" in this string, since it's AXRole is a group
Comment 4 Nan Wang 2016-10-06 23:48:41 PDT 
Created attachment 290904 [details]
patch

updated the string.
Comment 5 WebKit Commit Bot 2016-10-07 10:47:22 PDT 
Comment on attachment 290904 [details]
patch

Clearing flags on attachment: 290904

Committed r206921: <http://trac.webkit.org/changeset/206921>
Comment 6 WebKit Commit Bot 2016-10-07 10:47:26 PDT 
All reviewed patches have been landed.  Closing bug.