Bug 163089

Summary: URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Alex Christensen 2016-10-06 14:42:04 PDT
URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
Comment 1 Alex Christensen 2016-10-06 14:45:03 PDT
Created attachment 290867 [details]
Patch
Comment 2 Alex Christensen 2016-10-06 15:39:44 PDT
Created attachment 290870 [details]
Patch
Comment 3 Tim Horton 2016-10-06 15:46:08 PDT
Comment on attachment 290870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290870&action=review

> Source/WebCore/platform/URL.cpp:471
>          // For UTF-{7,16,32}, we want to use UTF-8 for the query part as

Maybe schlurp the comment out?

> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:1201
> +    if (testTabs == TestTabs::Yes) {

Why not an early return :)
Comment 4 Alex Christensen 2016-10-06 16:07:59 PDT
http://trac.webkit.org/changeset/206887