Bug 163014

Summary:

CachedResource client handling methods should take reference

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2016-10-06 08:05:21 PDT

CachedResource client handling methods should take reference

Comment 1 youenn fablet 2016-10-06 08:07:39 PDT

Created attachment 290823 [details]
Patch

Comment 2 Alex Christensen 2016-10-06 09:12:39 PDT

Comment on attachment 290823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290823&action=review

> Source/WebCore/rendering/style/StyleCachedImage.cpp:188
> +    ASSERT(renderer);

We should go and make this a reference, too

Comment 3 WebKit Commit Bot 2016-10-06 09:56:29 PDT

Comment on attachment 290823 [details]
Patch

Clearing flags on attachment: 290823

Committed r206867: <http://trac.webkit.org/changeset/206867>

Comment 4 WebKit Commit Bot 2016-10-06 09:56:32 PDT

All reviewed patches have been landed.  Closing bug.