Bug 163004

Summary:

CachedResourceRequest should not need to store defer and preload options

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, japhet

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2016-10-06 03:12:38 PDT

This should be handled by CachedResourceLoader internally.

Comment 1 youenn fablet 2016-10-06 03:16:58 PDT

Created attachment 290806 [details]
Patch

Comment 2 Alex Christensen 2016-10-06 08:59:26 PDT

Comment on attachment 290806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290806&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:192
> +    auto defer = clientDefersImage(request.resourceRequest().url()) ? DeferOption::DeferredByClient : DeferOption::NoDefer;

I think this auto should be bool.

Comment 3 youenn fablet 2016-10-06 22:39:59 PDT

Thanks for the review.

> > Source/WebCore/loader/cache/CachedResourceLoader.cpp:192
> > +    auto defer = clientDefersImage(request.resourceRequest().url()) ? DeferOption::DeferredByClient : DeferOption::NoDefer;
> 
> I think this auto should be bool.

defer is of type enum class DeferOption.

Comment 4 WebKit Commit Bot 2016-10-06 23:02:41 PDT

Comment on attachment 290806 [details]
Patch

Clearing flags on attachment: 290806

Committed r206900: <http://trac.webkit.org/changeset/206900>

Comment 5 WebKit Commit Bot 2016-10-06 23:02:45 PDT

All reviewed patches have been landed.  Closing bug.