Bug 163003

Summary: [Readable Streams API] Implement generic reader functions
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, youennf
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Romain Bellessort
Reported 2016-10-06 03:09:06 PDT
To prepare implementation of BYOBReader, reader generic functions should be implemented (readableStreamReaderGenericCancel/Initialize/Release).
Attachments
Patch (5.90 KB, patch)
2016-10-06 03:29 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Patch (5.91 KB, patch)
2016-10-07 01:21 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-10-06 03:29:29 PDT
Created attachment 290808 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-06 12:39:13 PDT
Comment on attachment 290808 [details] Patch Rejecting attachment 290808 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 290808, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ded at 1 with fuzz 3. patching file Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js Hunk #2 FAILED at 57. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js.rej patching file Source/WebCore/Modules/streams/ReadableStreamInternals.js Hunk #1 succeeded at 36 with fuzz 2. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2233005
Romain Bellessort
Comment 3 2016-10-07 01:21:51 PDT
Created attachment 290913 [details] Patch
Romain Bellessort
Comment 4 2016-10-07 01:23:43 PDT
Commit queue failed due to a previous commit (usage of @throwTypeError). Appropriate merge was done in the new version of the patch.
WebKit Commit Bot
Comment 5 2016-10-07 08:13:17 PDT
Comment on attachment 290913 [details] Patch Clearing flags on attachment: 290913 Committed r206912: <http://trac.webkit.org/changeset/206912>
WebKit Commit Bot
Comment 6 2016-10-07 08:13:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.