Bug 163002

Summary: Add a place for common HTTP Header values
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-10-06 01:35:54 PDT
Some HTTP header values like content type are often used in various places.
Attachments
Patch (12.59 KB, patch)
2016-10-06 01:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.62 KB, patch)
2016-10-06 22:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-10-06 01:38:24 PDT
Created attachment 290796 [details] Patch
Alex Christensen
Comment 2 2016-10-06 08:43:51 PDT
Comment on attachment 290796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290796&action=review > Source/WebCore/ChangeLog:3 > + Add a place for usual HTTP Header values usual -> common?
youenn fablet
Comment 3 2016-10-06 22:29:33 PDT
Created attachment 290896 [details] Patch for landing
youenn fablet
Comment 4 2016-10-06 22:29:52 PDT
Thanks for the review. > > Source/WebCore/ChangeLog:3 > > + Add a place for usual HTTP Header values > > usual -> common? Done
WebKit Commit Bot
Comment 5 2016-10-06 23:03:55 PDT
Comment on attachment 290896 [details] Patch for landing Clearing flags on attachment: 290896 Committed r206901: <http://trac.webkit.org/changeset/206901>
WebKit Commit Bot
Comment 6 2016-10-06 23:03:59 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2016-10-07 09:23:09 PDT
Comment on attachment 290896 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=290896&action=review > Source/WebCore/platform/network/HTTPHeaderValues.h:31 > +struct HTTPHeaderValues { What is the benefit to using a struct instead of a namespace here? > Source/WebCore/platform/network/HTTPHeaderValues.h:33 > + static const String& TextPlainContentType(); > + static const String& FormURLEncodedContentType(); This doesn’t match WebKit coding style. Function names should start with a lower case letter.
Alex Christensen
Comment 8 2016-10-10 11:11:55 PDT
https://bugs.webkit.org/show_bug.cgi?id=163203
Note You need to log in before you can comment on or make changes to this bug.