Bug 162999

Summary:

AX:[Mac] Unable to edit text input, textarea fields in iframe using VO naivgation

Product:

WebKit

Reporter:

Nan Wang <n_wang>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, ryanhaddad, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	cfleizach: review+

Description Nan Wang 2016-10-05 23:55:01 PDT

When using webkit1 web view, it's unable to edit user editable fields in iframe when using VO navigation to access them.

Comment 1 Radar WebKit Bug Importer 2016-10-05 23:55:26 PDT

<rdar://problem/28647519>

Comment 2 Nan Wang 2016-10-06 00:12:20 PDT

Created attachment 290787 [details]
patch

Comment 3 chris fleizach 2016-10-06 00:24:41 PDT

Comment on attachment 290787 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290787&action=review

> Source/WebCore/ChangeLog:8
> +        In webkit1, the top web area setting the selection to an input element inside an iframe

WebKit1

> Source/WebCore/ChangeLog:11
> +        the input's frame and cause unwanted behavior. Fixed it by not setting the selection in such case.

What was the unwanted behavior?

Fixed it -> I fixed it

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2043
> +    // In webkit1, when the top web area sets the selection to be an input element in an iframe, the caret will disappear.

In WebKit1

Comment 4 Nan Wang 2016-10-06 00:39:08 PDT

Created attachment 290789 [details]
patch

update from review

Comment 5 chris fleizach 2016-10-06 00:40:59 PDT

Comment on attachment 290789 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290789&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2045
> +    if (isWebArea() && parentObject() && parentObject()->isAttachment()) {

we should probably put this in a helper method.

isRangeInDifferentDocument(range)

or something to that effect

thanks

Comment 6 Nan Wang 2016-10-06 01:06:12 PDT

Committed r206854: <http://trac.webkit.org/changeset/206854>

Comment 7 Ryan Haddad 2016-10-06 09:23:47 PDT

The LayoutTest added with this change was asserting on mac-wk2 debug testers. Based on the changelog (and test name), I going to assume this isn't expected to work on wk2.

Skipped test on mac-wk2 in http://trac.webkit.org/projects/webkit/changeset/206865