Bug 162983

Summary: Make it possible to test ViewSnapshotStore behaviors
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, andersca, bdakin, mitz, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Tim Horton
Reported 2016-10-05 13:21:52 PDT
Make it possible to test ViewSnapshotStore behaviors
Attachments
Patch (27.04 KB, patch)
2016-10-05 13:23 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-10-05 13:23:27 PDT
Created attachment 290745 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-10-05 13:53:14 PDT
Comment on attachment 290745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290745&action=review > Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233 > +CGImageRef ViewSnapshot::asImageForTesting() I would prefer this as a "create" or "copy" function.
Tim Horton
Comment 3 2016-10-05 14:17:09 PDT
https://trac.webkit.org/changeset/206829
Anders Carlsson
Comment 4 2016-10-05 15:35:19 PDT
Comment on attachment 290745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290745&action=review >> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233 >> +CGImageRef ViewSnapshot::asImageForTesting() > > I would prefer this as a "create" or "copy" function. I would have preferred if this just returned a RetainPtr.
Note You need to log in before you can comment on or make changes to this bug.