Summary: | [DOMJIT] Add DOMJIT::Signature | ||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||||||||||||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, darin, fpizlo, saam, sam | ||||||||||||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||
Bug Depends on: | 163226, 163657, 163900, 164199 | ||||||||||||||||||||||||||||||||||||||
Bug Blocks: | 162544, 164356 | ||||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2016-10-05 10:56:54 PDT
Second one can be later extended to support DOM Binding interpreter. It emits byte code instead of C++ native code. And it will be executed by DOM Binding interpreter. While it does not pose any perf benefit (or it may cause some regression), it reduces amount of memory used for DOM binding native code. And we have a chance to annotate clobber information of methods. And it allows DFG to hoist / eliminate the operation. Start working on this. Since we already have DOMJIT::Effect, this should be easy! Created attachment 293285 [details]
Patch
WIP
Created attachment 293533 [details]
Patch
WIP
Created attachment 293605 [details]
Patch
WIP
Created attachment 293640 [details]
Patch
PFR Oops, rebasing. Created attachment 293641 [details]
Patch
OK, rebasing is done. Ready for reviews! Attachment 293641 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 16 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293642 [details]
Patch
Attachment 293642 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 16 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293644 [details]
Patch
Attachment 293644 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 16 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293647 [details]
Patch
Attempt to fix internal compiler error in GCC............... Attachment 293647 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:48: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:49: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:50: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:51: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:52: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:53: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:54: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:55: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:57: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:58: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:59: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:60: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:61: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:62: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:64: More than one command on the same line [whitespace/newline] [4]
Total errors found: 33 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293647&action=review > Source/JavaScriptCore/ChangeLog:28 > + LICM in Dromaeo dom-attr test. In the Dromaeo dom-attr getAttribute test, we can see 32x improvement. (134974.8 v.s. 4203.4) Amazing! Created attachment 293680 [details]
Patch
Attachment 293680 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 16 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293681 [details]
Patch
Attachment 293681 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:48: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:49: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:50: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:51: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:52: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:53: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:54: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:55: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:57: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:58: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:59: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:60: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:61: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:62: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:64: More than one command on the same line [whitespace/newline] [4]
Total errors found: 33 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293682 [details]
Patch
Attachment 293682 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:48: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:49: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:50: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:51: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:52: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:53: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:54: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:55: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:57: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:58: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:59: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:60: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:61: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:62: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:64: More than one command on the same line [whitespace/newline] [4]
Total errors found: 33 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #20) > Comment on attachment 293647 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=293647&action=review > > > Source/JavaScriptCore/ChangeLog:28 > > + LICM in Dromaeo dom-attr test. In the Dromaeo dom-attr getAttribute test, we can see 32x improvement. (134974.8 v.s. 4203.4) > > Amazing! Yay! It paves the way to annotate C++ functions with effects. I think eventually we can extend this mechanism to the C++ functions that is not related to DOM. Like String.prototype.xxx functions in JSC. It sometimes successfully annotates the function with like "It does not modify the heap!". And it gives us a chance to perform CSE, LICM, and other great DFG optimizations! Created attachment 293688 [details]
Patch
Attachment 293688 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:48: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:49: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:50: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:51: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:52: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:53: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:54: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:55: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:57: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:58: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:59: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:60: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:61: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:62: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:64: More than one command on the same line [whitespace/newline] [4]
Total errors found: 33 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attempt to fix Windows build! Comment on attachment 293688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293688&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7338 > + silentSpillAllRegisters(resultRegs); > + int argumentCountIncludingThis = signature->argumentCount + 1; > + switch (argumentCountIncludingThis) { > + case 1: > + callOperation(reinterpret_cast<J_JITOperation_EP>(signature->unsafeFunction), extractResult(resultRegs), regs[0]); > + break; > + case 2: > + callOperation(reinterpret_cast<J_JITOperation_EPP>(signature->unsafeFunction), extractResult(resultRegs), regs[0], regs[1]); > + break; > + case 3: > + callOperation(reinterpret_cast<J_JITOperation_EPPP>(signature->unsafeFunction), extractResult(resultRegs), regs[0], regs[1], regs[2]); > + break; > + default: > + RELEASE_ASSERT_NOT_REACHED(); > + break; > + } > + > + silentFillAllRegisters(resultRegs); I'll use flushRegisters() instead later. Comment on attachment 293688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293688&action=review r=me Patch looks reasonable to me. It may be worth pinging review from somebody who knows the IDL generator on that part of the patch since I'm not familiar with that code. > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2620 > + if (argumentCountIncludingThis != static_cast<int>(1 + signature->argumentCount)) Can you also add a check for the maximum number of arguments we currently support, since the code in the rest of the DFG doesn't handle arbitrary number of arguments. Maybe also with a FIXME if we ever plan to extend the number of arguments. > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2703 > + case SpecBoolean: Can you also add an assert that we don't reach the default case. > Source/JavaScriptCore/dfg/DFGNode.cpp:230 > + for (unsigned i = 1, iz = numChildren(); i < iz; ++i) You don't need iz here, I'd just make the loop i < numChildren(). Also, this function should ASSERT or RELEASE_ASSERT that numChildren() <= 4. > Source/JavaScriptCore/dfg/DFGNode.h:2392 > + // Note that this does not include TailCall thingy intentionally. thingy => node types > Source/JavaScriptCore/dfg/DFGNode.h:2393 > + // CallDOM thingy are always converted from Call. thingy are => node type is > Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:714 > + case CallDOM: { Why would this ever be in the IR at this point? I would put it with the asserts saying it shouldn't be in the IR. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7270 > + Vector<Variant<SpeculateCellOperand, SpeculateInt32Operand, SpeculateBooleanOperand>> operands; > + Vector<GPRReg> regs; Nit: I'd give tese an inline capacity of 3 or 4 or whatever the max number of arguments for now are. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7321 > + silentSpillAllRegisters(resultRegs); This should just be a flushRegisters() since you'll never have a non-call path. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7338 > + silentFillAllRegisters(resultRegs); and then you can remove this. > Source/JavaScriptCore/domjit/DOMJITHeapRange.h:88 > + static_assert(begin <= end, "begin <= end is the invariant of this HeapRange."); I thought begin must be strictly less than end? Or is that only if we're not none()? If so, maybe this can be stricter: (begin < end) || (begin == UINT16_MAX && end == UINT16_MAX) > Source/JavaScriptCore/domjit/DOMJITSignature.h:35 > +// Eventually, we should extend this. But possibly, 2 or 3 can cover typical use cases. I would open a FIXME for this. > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:9134 > + int argumentCountIncludingThis = signature->argumentCount + 1; nit: should be unsigned integer. Comment on attachment 293688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293688&action=review Thanks, I'll update the patch wit your comment. And request IDL review. >> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2620 >> + if (argumentCountIncludingThis != static_cast<int>(1 + signature->argumentCount)) > > Can you also add a check for the maximum number of arguments we currently support, since the code in the rest of the DFG doesn't handle arbitrary number of arguments. > Maybe also with a FIXME if we ever plan to extend the number of arguments. Added assertion here. And FIXME exists on DOMJIT::Signature. But we also add the FIXME here. >> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2703 >> + case SpecBoolean: > > Can you also add an assert that we don't reach the default case. Sure! Added. >> Source/JavaScriptCore/dfg/DFGNode.cpp:230 >> + for (unsigned i = 1, iz = numChildren(); i < iz; ++i) > > You don't need iz here, I'd just make the loop i < numChildren(). > Also, this function should ASSERT or RELEASE_ASSERT that numChildren() <= 4. Fixed. >> Source/JavaScriptCore/dfg/DFGNode.h:2392 >> + // Note that this does not include TailCall thingy intentionally. > > thingy => node types Fixed. >> Source/JavaScriptCore/dfg/DFGNode.h:2393 >> + // CallDOM thingy are always converted from Call. > > thingy are => node type is Fixed. >> Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:714 >> + case CallDOM: { > > Why would this ever be in the IR at this point? I would put it with the asserts saying it shouldn't be in the IR. Oops, right. It is not necessary. Dropped. Add CallDOM to the DFG_CRASH clause. >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7270 >> + Vector<GPRReg> regs; > > Nit: I'd give tese an inline capacity of 3 or 4 or whatever the max number of arguments for now are. Sounds nice. Fixed. >>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7338 >>> + silentFillAllRegisters(resultRegs); >> >> I'll use flushRegisters() instead later. > > and then you can remove this. Yeah, right. Dropped. >> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:9134 >> + int argumentCountIncludingThis = signature->argumentCount + 1; > > nit: should be unsigned integer. Fixed. Comment on attachment 293688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293688&action=review >> Source/JavaScriptCore/domjit/DOMJITHeapRange.h:88 >> + static_assert(begin <= end, "begin <= end is the invariant of this HeapRange."); > > I thought begin must be strictly less than end? Or is that only if we're not none()? > If so, maybe this can be stricter: > (begin < end) || (begin == UINT16_MAX && end == UINT16_MAX) Yeah, right. I'll make this assertion stricter. Comment on attachment 293688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293688&action=review >> Source/JavaScriptCore/domjit/DOMJITSignature.h:35 >> +// Eventually, we should extend this. But possibly, 2 or 3 can cover typical use cases. > > I would open a FIXME for this. Yeah, opened. https://bugs.webkit.org/show_bug.cgi?id=164346 Created attachment 293717 [details]
Patch
Created attachment 293724 [details]
Patch
Attachment 293724 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 16 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293728 [details]
Patch
Attachment 293728 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 16 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293728 [details]
Patch
Oops, rebasing is performed on to the incorrect branch. Fixing...
Created attachment 293733 [details]
Patch
Attachment 293733 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:48: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:49: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:50: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:51: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:52: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:53: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:54: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:55: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:57: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:58: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:59: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:60: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:61: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:62: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:64: More than one command on the same line [whitespace/newline] [4]
Total errors found: 33 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
OK. I would like to request reviews for IDL code generator part. Could you review this, Chris, Alex, or Sam? Created attachment 293738 [details]
Patch
Small fix for IDL when Atomic string ones are required as an argument
Attachment 293738 [details] did not pass style-queue:
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLType.h:42: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:42: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/NativeExecutable.h:87: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:35: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:36: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:37: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:38: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:39: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:40: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:41: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:48: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:49: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:50: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:51: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:52: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:53: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:54: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:55: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:57: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:58: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:59: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:60: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:61: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:62: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/domjit/DOMJITIDLTypeFilter.h:64: More than one command on the same line [whitespace/newline] [4]
Total errors found: 33 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293738 [details]
Patch
r=me on the IDL parts.
Committed r208320: <http://trac.webkit.org/changeset/208320> Will fix CLoop build soon. Committed r208323: <http://trac.webkit.org/changeset/208323> |