Bug 162967

Summary: [Readable Streams API] Align function names with spec
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, youennf
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Romain Bellessort
Reported 2016-10-05 05:35:57 PDT
Readable Streams API implementation has globally been aligned with latest spec, but functions names were not always updated in order to ease patch review. In some cases, this leads to inconsistencies (e.g. enqueueInReadableStream takes a controller argument whereas its name suggests it works on a stream). Aligning with spec names would make code more coherent and ease comparison between implementation and spec.
Attachments
Patch (13.99 KB, patch)
2016-10-05 05:51 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-10-05 05:51:32 PDT
Created attachment 290706 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-05 09:48:48 PDT
Comment on attachment 290706 [details] Patch Clearing flags on attachment: 290706 Committed r206814: <http://trac.webkit.org/changeset/206814>
WebKit Commit Bot
Comment 3 2016-10-05 09:48:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.