Bug 162956

Summary: UTF-8 encode queries of nonspecial and websocket schemes
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: saam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2016-10-04 23:32:36 PDT
UTF-8 encode queries of nonspecial and websocket schemes
Attachments
Patch (15.49 KB, patch)
2016-10-05 00:05 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.90 KB, patch)
2016-10-05 11:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-10-05 00:05:59 PDT
Created attachment 290693 [details] Patch
Alex Christensen
Comment 2 2016-10-05 11:03:35 PDT
Created attachment 290728 [details] Patch
Geoffrey Garen
Comment 3 2016-10-05 11:11:42 PDT
Comment on attachment 290728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290728&action=review r=me > Source/WebCore/ChangeLog:9 > + 'If url is not special or urlâs scheme is either "ws" or "wss", set encoding to UTF-8.' ASCII in ChangeLog please.
Brady Eidson
Comment 4 2016-10-05 11:14:47 PDT
Comment on attachment 290728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290728&action=review > Source/WebCore/platform/URLParser.cpp:680 > + Ws, > + Wss, All caps > Source/WebCore/platform/URLParser.cpp:682 > + Ftp, All caps > Source/WebCore/platform/URLParser.cpp:685 > + Http, > + Https, All caps
Alex Christensen
Comment 5 2016-10-05 11:28:03 PDT
Done, and added a gopher test just for fun http://trac.webkit.org/changeset/206818
Note You need to log in before you can comment on or make changes to this bug.