Bug 162956

Summary: UTF-8 encode queries of nonspecial and websocket schemes
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: saam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2016-10-04 23:32:36 PDT 
UTF-8 encode queries of nonspecial and websocket schemes
Comment 1 Alex Christensen 2016-10-05 00:05:59 PDT 
Created attachment 290693 [details]
Patch
Comment 2 Alex Christensen 2016-10-05 11:03:35 PDT 
Created attachment 290728 [details]
Patch
Comment 3 Geoffrey Garen 2016-10-05 11:11:42 PDT 
Comment on attachment 290728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290728&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        'If url is not special or urlâs scheme is either "ws" or "wss", set encoding to UTF-8.'

ASCII in ChangeLog please.
Comment 4 Brady Eidson 2016-10-05 11:14:47 PDT 
Comment on attachment 290728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290728&action=review

> Source/WebCore/platform/URLParser.cpp:680
> +    Ws,
> +    Wss,

All caps

> Source/WebCore/platform/URLParser.cpp:682
> +    Ftp,

All caps

> Source/WebCore/platform/URLParser.cpp:685
> +    Http,
> +    Https,

All caps
Comment 5 Alex Christensen 2016-10-05 11:28:03 PDT 
Done, and added a gopher test just for fun
http://trac.webkit.org/changeset/206818