Summary: | [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> | ||||||||||
Component: | Platform | Assignee: | Enrique Ocaña <eocanha> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | calvaris | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 157314 | ||||||||||||
Attachments: |
|
Description
Enrique Ocaña
2016-10-04 11:43:34 PDT
Created attachment 290631 [details]
Patch
Comment on attachment 290631 [details]
Patch
Wait until all the patches in 157314 are ready.
Comment on attachment 290631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290631&action=review > Tools/Scripts/webkitperl/FeatureList.pm:256 > + define => "ENABLE_ENCRYPTED_MEDIA_V2", default => isGtk(), value => \$encryptedMediaV2Support }, heads up - this was renamed in https://bugs.webkit.org/show_bug.cgi?id=162903 Comment on attachment 290631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290631&action=review As Alex says, better to wait until the changes are done before rebasing this. > Source/WebCore/platform/GStreamer.cmake:127 > + "${WEBCORE_DIR}/platform/graphics/gstreamer/eme" If header files are properly flagged with *ENCRYPTED_MEDIA*, you can move this to the common section. > Source/WebCore/platform/GStreamer.cmake:136 > + list(APPEND WebCore_SOURCES > + platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp > + platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp If these files are properly flagged with *ENCRYPTED_MEDIA*, you can move this to the common section. > Source/cmake/FindLibGcrypt.cmake:18 > +# Copyright 2014 Nicolás Alvarez <nicolas.alvarez@gmail.com> I think you can add our copyright here. Created attachment 291774 [details]
Patch
Created attachment 292904 [details]
Patch
Created attachment 292905 [details]
Patch
Comment on attachment 292905 [details] Patch Clearing flags on attachment: 292905 Committed r207891: <http://trac.webkit.org/changeset/207891> All reviewed patches have been landed. Closing bug. |