Bug 162903 - Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
Summary: Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-04 07:17 PDT by Zan Dobersek
Modified: 2016-10-05 09:05 PDT (History)
4 users (show)

See Also:

Attachments
EWS run (127.19 KB, patch)
2016-10-04 07:28 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (129.25 KB, patch)
2016-10-05 00:29 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-10-04 07:17:00 PDT 
Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
Comment 1 Zan Dobersek 2016-10-04 07:27:21 PDT 
The remaining EME API implementation uses the ENABLE_ENCRYPTED_MEDIA_V2 guards. That should be renamed to ENABLE_LEGACY_ENCRYPTED_MEDIA.

This bug covers build guards. The next step, as proposed by Jer, would be using hard-encoded 'WebKit' prefixes throughout the implementation for this legacy API.
Comment 2 Zan Dobersek 2016-10-04 07:28:48 PDT 
Created attachment 290599 [details]
EWS run
Comment 3 WebKit Commit Bot 2016-10-04 07:31:38 PDT 
Attachment 290599 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 92 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Zan Dobersek 2016-10-05 00:29:19 PDT 
Created attachment 290694 [details]
Patch
Comment 5 Zan Dobersek 2016-10-05 09:05:06 PDT 
Comment on attachment 290694 [details]
Patch

Clearing flags on attachment: 290694

Committed r206811: <http://trac.webkit.org/changeset/206811>
Comment 6 Zan Dobersek 2016-10-05 09:05:15 PDT 
All reviewed patches have been landed.  Closing bug.