Summary: | [Win][Direct2D] Connect WebCore/WebKit Drawing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, dino, pvollan | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 161817 | ||||||
Attachments: |
|
Description
Brent Fulgham
2016-10-04 11:08:04 PDT
Created attachment 290675 [details]
Patch
Attachment 290675 [details] did not pass style-queue:
ERROR: Source/WebKit/win/WebView.cpp:1146: Use the class HWndDC instead of calling GetDC to avoid potential memory leaks. [runtime/leaky_pattern] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 290675 [details] did not pass style-queue: > > > ERROR: Source/WebKit/win/WebView.cpp:1146: Use the class HWndDC instead of > calling GetDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] > Total errors found: 1 in 6 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This is an error in the style checker. The 'GetDC' function here is a conversion routine from Direct2D. It has nothing to do with the HWndDC class. Comment on attachment 290675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290675&action=review > Source/WebKit/win/WebView.cpp:1246 > + m_renderTarget->SetTags(2, __LINE__); Why? > Source/WebKit/win/WebView.cpp:1276 > + (void)hr; Just don't name hr. Comment on attachment 290675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290675&action=review >> Source/WebKit/win/WebView.cpp:1246 >> + m_renderTarget->SetTags(2, __LINE__); > > Why? This is a debugging function. I'll add a macro for the first argument. When Flush or EndDraw has an error, it outputs these two numbers, which can be used to identify which drawing logic was executing at the time of a failure. >> Source/WebKit/win/WebView.cpp:1276 >> + (void)hr; > > Just don't name hr. I'll use UNUSED_PARAM, since I want access to 'hr' when debugging so I can see what the error was. Committed r206816: <http://trac.webkit.org/changeset/206816> |