Bug 162911

Summary: [GStreamer][MSE][EME] Remove MSE code from regular player and add EME support
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: PlatformAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 157314    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Enrique Ocaña
Reported 2016-10-04 09:33:13 PDT
Now that the MSE responsibility has been refactored to the dedicated MediaPlayerPrivateGStreamerMSE subclass, the regular player no longer needs the MSE code, just to expose some more methods to the subclass. Also, small changes to accomodate the EME support are needed.
Attachments
Patch (32.37 KB, patch)
2016-10-04 09:59 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (32.43 KB, patch)
2016-10-16 12:09 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (32.43 KB, patch)
2016-10-26 01:22 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Enrique Ocaña
Comment 1 2016-10-04 09:59:51 PDT
Created attachment 290609 [details] Patch
Enrique Ocaña
Comment 2 2016-10-04 10:07:07 PDT
Comment on attachment 290609 [details] Patch Wait until all the patches in 157314 are ready.
Xabier Rodríguez Calvar
Comment 3 2016-10-08 07:23:19 PDT
Comment on attachment 290609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290609&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:309 > + auto mediaDuration = durationMediaTime(); Type this, please > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:625 > + if (!m_pipeline || !m_source) UNLIKELY? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:690 > + if (!m_pipeline || !m_source) UNLIKELY? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:743 > + if (!m_pipeline || !m_source) UNLIKELY? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1272 > + if (!m_pipeline || !durationMediaTime() || (!isMediaSource() && !totalBytes())) UNLIKELY? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1645 > + auto now = currentMediaTime(); Type this, please
Enrique Ocaña
Comment 4 2016-10-16 12:09:19 PDT
Created attachment 291768 [details] Patch
Enrique Ocaña
Comment 5 2016-10-26 01:22:39 PDT
Created attachment 292898 [details] Patch
Enrique Ocaña
Comment 6 2016-10-26 01:47:35 PDT
Comment on attachment 292898 [details] Patch Clearing flags on attachment: 292898 Committed r207885: <http://trac.webkit.org/changeset/207885>
Enrique Ocaña
Comment 7 2016-10-26 01:47:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.