Bug 162903

Summary: Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, calvaris, commit-queue, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
EWS run
none
Patch none

Zan Dobersek
Reported 2016-10-04 07:17:00 PDT
Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
Attachments
EWS run (127.19 KB, patch)
2016-10-04 07:28 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (129.25 KB, patch)
2016-10-05 00:29 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-10-04 07:27:21 PDT
The remaining EME API implementation uses the ENABLE_ENCRYPTED_MEDIA_V2 guards. That should be renamed to ENABLE_LEGACY_ENCRYPTED_MEDIA. This bug covers build guards. The next step, as proposed by Jer, would be using hard-encoded 'WebKit' prefixes throughout the implementation for this legacy API.
Zan Dobersek
Comment 2 2016-10-04 07:28:48 PDT
Created attachment 290599 [details] EWS run
WebKit Commit Bot
Comment 3 2016-10-04 07:31:38 PDT
Attachment 290599 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 92 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 4 2016-10-05 00:29:19 PDT
Created attachment 290694 [details] Patch
Zan Dobersek
Comment 5 2016-10-05 09:05:06 PDT
Comment on attachment 290694 [details] Patch Clearing flags on attachment: 290694 Committed r206811: <http://trac.webkit.org/changeset/206811>
Zan Dobersek
Comment 6 2016-10-05 09:05:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.